-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI for v3.0.1 publication #1100
Conversation
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
…s directories Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@licquia here's the new CI for 3.0.1. Please kindly review. Thank you.
|
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
- Add back index.md since it is required as a home page, without it https://spdx.github.io/spdx-spec/v3.0.1/ will be 404 as there is no index.html generated - Rename docs/front/index.md to docs/front/copyright.md Signed-off-by: Arthit Suriyawongkul <[email protected]>
Ping @zvr - I have to add Because without it, URLs like https://spdx.github.io/spdx-spec/v3.0/ and https://spdx.github.io/spdx-spec/v3.0.1/ will return 404 File Not Found as there is no Not sure if this will affect the ISO/OMG submissions or not, we will figure out, but in any case the index.md really has be at that exact location :( UPDATE: it is now fixed by #1101 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't see any issue - but it is a very large set of changes so some additional reviews would be helpful.
The redirects-map probably needs another set of eyes as well as the CI logic
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Thank you. It is really a huge changeset. I just added comments explaining few steps more in the publish_v3.yml to facilitate the review. |
- Add more comments and example to Redirection step - Move make MkDocs config script to bin + add more comments/usage - Revert newlines changes in submissions/ dir Signed-off-by: Arthit Suriyawongkul <[email protected]>
- v3.0/introduction --> v3.0.1/front/introduction - v3.0/normative-references --> v3.0.1/references - v3.0/bibliography --> v3.0.1/references Signed-off-by: Arthit Suriyawongkul <[email protected]>
I think this whole thing got too complicated and not easy to review. I'll approve it and merge it and then we can incrementally fix issues (if there are any). |
Summary
Updated CI for v3.0.1 publication and new spec-parser directory structure
RDF_BASE_DIR
andMKDOCS_BASE_DIR
values in.github/workflows/publish_v3.yml
to "rdf" and "mkdocs" (see comments at Lines 24-25)REF_SPEC
,REF_MODEL
, andREF_PARSER
values in.github/workflows/publish_v3.yml
(see Lines 14-16)Will resolve #996, resolve #1018, resolve #1069
Removal of old workflows
This PR also remove
.github/workflows/publish.yml
and.github/workflows/publish_common.yml
as they are no longer in use for v3 publication.All of them are still available in v2 branches.
For example, https://github.com/spdx/spdx-spec/tree/development/v2.3/.github/workflows
Main workflow steps
Below are steps in
.github/workflows/publish_v3.yml
.The big ones are the last two where they do extra work to keep old URLs working.
The YAML file has more comments.
so it can be accessible from all old URLs for backward compatibility.
will all accessible and have the same content.
imports
to redirect to its new name atimport
.First value is 'from' (source), second value is 'to' (target).
Demo
The demo of this workflow is at https://bact.github.io/spdx-spec/
To see what the workflow will look like when running, see a log at
https://github.com/bact/spdx-spec/actions/runs/10716224938
(this is deployed on my own personal repo, not the spdx one).
Redirection tests
To illustrates the redirection, here are some example.