bugfix: remove 'name' in snippets' required field and add 'documentNamespace' to doc's required field #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR failed because there's no signed-off information in the commit message. To fix it, see: https://github.com/spdx/spdx-spec/pull/1021/checks?check_run_id=28332639903 |
… to doc's required field Signed-off-by: David Liu <[email protected]>
ammend
force-pushed
the
development/v2.2.2
branch
from
337efa6
to
0fb094c
Compare
@goneall Thanks for your review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove 'name' in snippets' required field and add 'documentNamespace' to doc's required field according to official spdx website. By the link below, 'documentNamespace' is required in the specification link however it not not required in json schema. And 'name' is not required in the specification link however it is required in json schema.