Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning for PHP 8.4 implicit nullable parameter #180

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

hmazter
Copy link
Contributor

@hmazter hmazter commented Dec 16, 2024

Since PHP 8.4 Implicitly marking parameters as nullable is deprecated, the explicit nullable type must be used instead.

For example change Style $style = null => ?Style $style = null

Since PHP 8.4 Implicitly marking parameters as nullable is deprecated, the explicit nullable type must be used instead.
For example change `Style $style = null` => `?Style $style = null`
@Nielsvanpach Nielsvanpach marked this pull request as ready for review December 16, 2024 09:49
@hmazter hmazter changed the title Fix deprecation warning for PHP 8.4 implicit nullable Fix deprecation warning for PHP 8.4 implicit nullable parameter Dec 16, 2024
@freekmurze freekmurze merged commit 1dfc9c0 into spatie:main Dec 16, 2024
10 checks passed
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants