[BREAKING] Fix empty param bag #82
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this test demonstrates that scopes can be accessed in the transformers
Mohammad-Alavi
commented
Dec 7, 2024
Comment on lines
+25
to
+31
| if ($parentScope === 'author') { | ||
| $data['called_by_author'] = 'indeed!'; | ||
| } | ||
|
|
||
| if ($parentScope === 'books') { | ||
| $data['called_by_book'] = 'yes!'; | ||
| } |
There was a problem hiding this comment.
As you can see, we are returnning different fields based on the context that we are in.
In the author context we return, called_by_author field, and
In the books context we return, called_by_book field.
It seems this is the reult that #39 wanted to achiev.
Mohammad-Alavi
commented
Dec 7, 2024
| @@ -405,7 +405,7 @@ public function createData() | |||
| $this->manager->parseFieldsets($this->fieldsets); | |||
| } | |||
|
|
|||
| return $this->manager->createData($this->getResource(), $this->resourceName); | |||
There was a problem hiding this comment.
This is the actual fix.
The rest are just tests 😬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
This PR is based on Test nested includes #79 and utilizes the test classes introduced there. To make the review process smoother, it’s recommended that this PR be merged after Test nested includes #79.Summary
This PR addresses #49 and #62, both of which were caused by the changes introduced in #39.
The issue occurs when using the withResourceName method or setting the resource name in any other way, causing the include parameters to be empty. This problem is clearly described in #62.
More Context
In the use case described in #38, if the data returned by Country differs depending on the context (e.g., in the Portfolio context vs. other contexts), it indicates that a different or new transformer should be used for each context. This is precisely what transformers and includes are designed for: to return different data based on context.
If you need to return different data based on context, it is still possible to do so, as demonstrated in the test case.
resolve #49
resolve #62