Skip to content

Commit

Permalink
ci: re-enable downstream sanitize test (#3397)
Browse files Browse the repository at this point in the history
**What problem is this PR intended to solve?**

In #3348, downstream CI tests for Sanitize were temporarily disabled
because the changes in that PR (intentionally) caused some of Sanitize's
tests to fail.

As of Sanitize 7.0.0, tests are passing again with the latest Nokogiri
and it's safe to re-enable the downstream tests. 🎉
  • Loading branch information
flavorjones authored Jan 2, 2025
2 parents ef36f2a + e694ac4 commit b519a0d
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions .github/workflows/downstream.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,10 @@ jobs:
name: rails-html-sanitizer
command: "bundle exec rake test"
ruby: "3.4"
# # pending a fix for https://github.com/sparklemotion/nokogiri/pull/3348
# - url: https://github.com/rgrove/sanitize
# name: sanitize
# command: "bundle exec rake test"
# ruby: "3.4"
- url: https://github.com/rgrove/sanitize
name: sanitize
command: "bundle exec rake test"
ruby: "3.4"
- url: https://github.com/ebeigarts/signer
name: signer
command: "bundle exec rake spec"
Expand Down

0 comments on commit b519a0d

Please sign in to comment.