py-fenics-dolfinx 0.10: bump version, refinements#3379
Open
jhale wants to merge 4 commits intospack:developfrom
Open
py-fenics-dolfinx 0.10: bump version, refinements#3379jhale wants to merge 4 commits intospack:developfrom
jhale wants to merge 4 commits intospack:developfrom
Conversation
spackbot-triage
bot
added
new-version
python
dependencies
update-package
conflicts
labels
spackbot-triage
bot
requested review from
chrisrichardson,
garth-wells and
nate-sime
jhale
commented
Feb 11, 2026
| depends_on("py-petsc4py", type=("build", "run")) | ||
| depends_on("py-slepc4py", type=("build", "run")) | ||
|
|
||
| depends_on("py-cffi@:1.16", type=("build", "run")) |
Contributor
Author
There was a problem hiding this comment.
This was added due to upstream bugs and is now unnecessary
jhale
commented
Feb 11, 2026
| depends_on("py-nanobind@2.5:", when="@0.10:", type="build") | ||
| depends_on("py-nanobind@2:", when="@0.9:", type="build") | ||
| depends_on("py-nanobind@1.8:1.9", when="@0.8", type="build") | ||
| depends_on("py-scikit-build-core@0.10: +pyproject", when="@0.10:", type="build") |
Contributor
Author
There was a problem hiding this comment.
Checked, this lower bound on scikit-build-core goes back to 0.9
jhale
commented
Feb 11, 2026
| depends_on("py-numpy@1.21:", type=("build", "run")) | ||
| depends_on("py-mpi4py", type=("build", "run")) | ||
|
|
||
| conflicts("~petsc4py", when="@:0.8", msg="+petsc4py is required for versions 0.8 and lower") |
Contributor
Author
There was a problem hiding this comment.
petsc4py was only an optional dependency from 0.9 and up.
Contributor
Author
There was a problem hiding this comment.
Will change this into a straightforward depend.
jhale
commented
Feb 11, 2026
| depends_on("py-mpi4py", type=("build", "run")) | ||
|
|
||
| conflicts("~petsc4py", when="@:0.8", msg="+petsc4py is required for versions 0.8 and lower") | ||
| conflicts("~petsc4py", when="+slepc4py", msg="+slepc4py requires +petsc4py") |
Contributor
Author
There was a problem hiding this comment.
A user cannot force +slepc4py and also try and force ~petsc4py - niche but correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #3369