REST API authentication #650
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Contributor
|
@sreeja-code-dev, get well soon! Feel free to remove unused imports. This imports are left by previous code versions. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #650 +/- ##
=========================================
Coverage 6.42% 6.42%
Complexity 262 262
=========================================
Files 331 331
Lines 10787 10787
Branches 879 879
=========================================
Hits 693 693
Misses 10040 10040
Partials 54 54 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
Alright 👍🏻 |
Contributor
|
PR is in progress. I've marked it as draft. Could you delete the draft when you're done? |
Author
|
Ok I will delete the draft when it is done . Currently making other authentication classes and working on the dependencies part also.👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I was unwell I could not work on the authorization portion. So I added the files which i created earlier during the preview of the codebase. One thing I noticed,the import statement for GenericGenerator is present in the file but the annotation itself is not being used on any field or class. Also the pom.xml file needs to update the springboot version and maven ascii dependency lifecycle part for full control of maven. I did not change anything over there until your permission. Unless they are fixed ,it is quite difficult to add the security part of the authentication process which may show problems. Issue -#68