-
Notifications
You must be signed in to change notification settings - Fork 35
TST: Uncomment ramp fitting compares and clean up test_ramp_fitting.py #425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
and clean up test_ramp_fitting.py to ease future maintenance
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #425 +/- ##
=======================================
Coverage 89.66% 89.67%
=======================================
Files 67 67
Lines 10430 10447 +17
=======================================
+ Hits 9352 9368 +16
- Misses 1078 1079 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
|
pre-commit failure looks like some server hiccup. I can clear it later after initial review. |
schlafly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thumbs up from the Roman side!
|
pre-commit.ci autofix |
|
Thanks, all! |
This PR uncomments ramp fitting test comparisons and clean up
test_ramp_fitting.pyto ease future maintenance. Not sure why they were commented back in #156No need for RT.
Can we get a fast turnaround on this one so I can build #421 on it? 🙏
Tasks
docs/pageno-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types)"git+https://github.com/<fork>/stcal@<branch>")jwstregression testromancalregression testnews fragment change types...
changes/<PR#>.apichange.rst: change to public APIchanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.general.rst: infrastructure or miscellaneous change