Skip to content

Conversation

@pllim
Copy link
Contributor

@pllim pllim commented Oct 30, 2025

This PR uncomments ramp fitting test comparisons and clean up test_ramp_fitting.py to ease future maintenance. Not sure why they were commented back in #156

No need for RT.

Can we get a fast turnaround on this one so I can build #421 on it? 🙏

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run regression tests with this branch installed ("git+https://github.com/<fork>/stcal@<branch>")
news fragment change types...
  • changes/<PR#>.apichange.rst: change to public API
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change

and clean up test_ramp_fitting.py to ease future maintenance
@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.67%. Comparing base (7673a52) to head (4dbe91d).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
tests/test_ramp_fitting.py 92.59% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #425   +/-   ##
=======================================
  Coverage   89.66%   89.67%           
=======================================
  Files          67       67           
  Lines       10430    10447   +17     
=======================================
+ Hits         9352     9368   +16     
- Misses       1078     1079    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pllim
Copy link
Contributor Author

pllim commented Oct 30, 2025

py3-xdist (macos-latest) will never run because it is picking up Python 3.14 (which this package disallows) and has been renamed to py313-xdist (macos-latest). This PR will need repo admin to override branch protection rule to merge, and then the admin has to update branch protection rule after merge.

@pllim
Copy link
Contributor Author

pllim commented Oct 30, 2025

pre-commit failure looks like some server hiccup. I can clear it later after initial review.

@pllim pllim marked this pull request as ready for review October 30, 2025 21:59
@pllim pllim requested a review from a team as a code owner October 30, 2025 21:59
Copy link
Collaborator

@schlafly schlafly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up from the Roman side!

@pllim
Copy link
Contributor Author

pllim commented Oct 31, 2025

pre-commit.ci autofix

@pllim pllim mentioned this pull request Oct 31, 2025
7 tasks
@tapastro tapastro merged commit 72b47c7 into spacetelescope:main Oct 31, 2025
24 checks passed
@pllim pllim deleted the exorcise-xxx branch October 31, 2025 15:39
@pllim
Copy link
Contributor Author

pllim commented Oct 31, 2025

Thanks, all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants