JP-3164: Update STCAL CI Tests #362
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #362 +/- ##
==========================================
+ Coverage 88.02% 89.74% +1.71%
==========================================
Files 64 64
Lines 9983 9965 -18
==========================================
+ Hits 8788 8943 +155
+ Misses 1195 1022 -173 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| # Make sure that groups after the third get flagged | ||
| assert np.all(gdq[0, 2:, 5, 5] == DQFLAGS["SATURATED"]) | ||
| assert np.all(gdq[0, 3:, 5, 5] == DQFLAGS["SATURATED"]) |
There was a problem hiding this comment.
I think the behavior introduced by #321 is not desirable long term; if we opt to remove the xfail here, we should at least add a comment describing the ideal state for future edits to the code and this test. I believe the long-term fix will be tracked under https://jira.stsci.edu/browse/JP-3835
emolter
left a comment
emolter
left a comment
There was a problem hiding this comment.
Overall these look good to me Ken, but what is the status of
stcal/tests/test_ramp_fitting_gls_fit.py
Line 196 in b4131aa
and fix tests. MNT: Add __all__ to ramp_fitting/utils.py DOC: Fix DQ propagation text. TST: Un-xfail test_read_pattern_saturation_flagging from spacetelescope#362
| assert np.all(gdq[0, 2:, 5, 5] == DQFLAGS["SATURATED"]) | ||
| # XXX - PR #321 introduced this behavior, but it may not be what's wanted. For now | ||
| # the xfail has been removed to test the current behavior. | ||
| assert np.all(gdq[0, 3:, 5, 5] == DQFLAGS["SATURATED"]) |
There was a problem hiding this comment.
I caught this one separately at #421 so I copied this part of the PR over to my PR there. FYI.
4 participants
Resolves JP-3164
This PR cleans up CI test removing or updating skipped or xfail'd tests.
Tasks
docs/pageno-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types)"git+https://github.com/<fork>/stcal@<branch>")jwstregression testromancalregression testnews fragment change types...
changes/<PR#>.apichange.rst: change to public APIchanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.general.rst: infrastructure or miscellaneous change