Inverse wcs bbox #314
Merged
Inverse wcs bbox #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #314 +/- ##
===========================================
+ Coverage 29.56% 86.88% +57.32%
===========================================
Files 37 49 +12
Lines 8332 8937 +605
===========================================
+ Hits 2463 7765 +5302
+ Misses 5869 1172 -4697 ☔ View full report in Codecov by Sentry. |
kmacdonald-stsci
approved these changes
Oct 30, 2024
|
Needs a change log fragment. |
nden
force-pushed
the
inverse-wcs-bbox
branch
from
f0dc386 to
7b49e44
Compare
nden
force-pushed
the
inverse-wcs-bbox
branch
from
19ba5b9 to
41c6fd4
Compare
WilliamJamieson
approved these changes
Dec 13, 2024
| @@ -20,7 +20,7 @@ dependencies = [ | |||
| "numpy >=1.21.2", | |||
| "opencv-python-headless >=4.6.0.66", | |||
| "asdf >=2.15.0", | |||
| "gwcs >= 0.18.1", | |||
| "gwcs @ git+https://github.com/nden/gwcs.git@inverse-bbox", | |||
There was a problem hiding this comment.
I think that if you remove this change we can merge this without too much fear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the work for AL-852: using the bounding_box in the inverse transforms.
It requires spacetelescope/gwcs#498 to be merged
Follow up PRs are spacetelescope/jwst#8554 and spacetelescope/romancal#1273
Closes #
This PR addresses ...
Tasks
docs/pageno-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see below for change types)"git+https://github.com/<fork>/stcal@<branch>")jwstregression testromancalregression testnews fragment change types...
changes/<PR#>.apichange.rst: change to public APIchanges/<PR#>.bugfix.rst: fixes an issuechanges/<PR#>.general.rst: infrastructure or miscellaneous change