RCAL-919: Formalize the patches (sky cells) file (e.g., add it as a reference file) #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perrygreenfield
requested review from
WilliamJamieson and
a team
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #524 +/- ##
=======================================
Coverage 96.24% 96.24%
=======================================
Files 4 4
Lines 213 213
=======================================
Hits 205 205
Misses 8 8 ☔ View full report in Codecov by Sentry. |
braingram
reviewed
Dec 10, 2024
| description: | | ||
| A structured array that contains relevant information about all the projection regions that | ||
| cover the entire celestial sphere. | ||
| source: 0 |
There was a problem hiding this comment.
Suggested change
| source: 0 |
I'm not aware of any source validator.
| title: Information about all skycells | ||
| description: | | ||
| Relevant information about all skycells that have been defined to cover the celesital sphere. | ||
| source: 1 |
There was a problem hiding this comment.
Suggested change
| source: 1 |
Same as above
braingram
reviewed
Dec 10, 2024
| $schema: asdf://stsci.edu/datamodels/roman/schemas/rad_schema-1.0.0 | ||
| id: asdf://stsci.edu/datamodels/roman/schemas/reference_files/roman_skycells-1.0.0 | ||
|
|
||
| title: Roman Skycells File Schema |
There was a problem hiding this comment.
Suggested change
| title: Roman Skycells File Schema | |
| title: Skycells File Schema |
While looking at the roman datamodels PR I noticed the roman prefixes there. Do we need these?
Same goes for the name of this file. Is skycells-1.0.0.yaml sufficient?
perrygreenfield
force-pushed
the
skycell
branch
from
ec7dc6b to
e9d9c1b
Compare
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves RCAL
This PR addresses the need to support the skycell definition file as a reference file
The schema to support this file has been added to RAD.