-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document image group usage for sky matching #9080
base: main
Are you sure you want to change the base?
Conversation
7855256
to
73d3395
Compare
73d3395
to
859c5bb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9080 +/- ##
=======================================
Coverage ? 76.94%
=======================================
Files ? 498
Lines ? 45844
Branches ? 0
=======================================
Hits ? 35273
Misses ? 10571
Partials ? 0
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fantastic Mihai. I just added a few comments to improve grammar/clarity slightly.
Co-authored-by: Ned Molter <[email protected]>
Co-authored-by: Ned Molter <[email protected]>
Co-authored-by: Ned Molter <[email protected]>
Co-authored-by: Ned Molter <[email protected]>
Co-authored-by: Ned Molter <[email protected]>
Co-authored-by: Ned Molter <[email protected]>
Co-authored-by: Ned Molter <[email protected]>
Resolves JP-3843
Fixes #9063
This PR adds description of image groups in relation to sky matching and when grouping is desirable or not.
Tasks
Build 11.3
(use the latest build if not sure)no-changelog-entry-needed
)changes/
:echo "changed something" > changes/<PR#>.<changetype>.rst
(see below for change types)docs/
pageokify_regtests
to update the truth files