Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document image group usage for sky matching #9080

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

mcara
Copy link
Member

@mcara mcara commented Jan 16, 2025

Resolves JP-3843
Fixes #9063

This PR adds description of image groups in relation to sky matching and when grouping is desirable or not.

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. Build 11.3 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@mcara mcara requested a review from a team as a code owner January 16, 2025 09:27
@mcara mcara force-pushed the skymatch-grouping branch from 7855256 to 73d3395 Compare January 16, 2025 09:36
@mcara mcara force-pushed the skymatch-grouping branch from 73d3395 to 859c5bb Compare January 16, 2025 09:42
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@e012b4e). Learn more about missing BASE report.
Report is 21 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9080   +/-   ##
=======================================
  Coverage        ?   76.94%           
=======================================
  Files           ?      498           
  Lines           ?    45844           
  Branches        ?        0           
=======================================
  Hits            ?    35273           
  Misses          ?    10571           
  Partials        ?        0           
Flag Coverage Δ *Carryforward flag
nightly 77.38% <ø> (?) Carriedforward from 5ce2717

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@emolter emolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic Mihai. I just added a few comments to improve grammar/clarity slightly.

docs/jwst/skymatch/description.rst Outdated Show resolved Hide resolved
docs/jwst/skymatch/description.rst Outdated Show resolved Hide resolved
docs/jwst/skymatch/description.rst Outdated Show resolved Hide resolved
docs/jwst/skymatch/description.rst Outdated Show resolved Hide resolved
docs/jwst/skymatch/description.rst Outdated Show resolved Hide resolved
docs/jwst/skymatch/description.rst Outdated Show resolved Hide resolved
docs/jwst/skymatch/description.rst Outdated Show resolved Hide resolved
@emolter emolter added this to the Build 11.3 milestone Jan 16, 2025
@mcara mcara requested a review from drlaw1558 January 16, 2025 19:45
@mcara mcara self-assigned this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate differences between user and pipeline match algorithm in skymatch
3 participants