-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JP-3664: Testing changes for numpy 2.0 compatibility #8718
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8718 +/- ##
==========================================
- Coverage 76.92% 66.99% -9.94%
==========================================
Files 498 377 -121
Lines 45810 38156 -7654
==========================================
- Hits 35240 25561 -9679
- Misses 10570 12595 +2025
☔ View full report in Codecov by Sentry. |
61f372c
to
bcba8a3
Compare
f90c0c6
to
37bab62
Compare
#8812 fixed most of the coron unit tests with numpy 2, but there's still one check that's barely out of spec on the Linux tests. I think changing these lines to atol=1e-4, rtol=1e-5 should work: jwst/jwst/coron/tests/test_coron.py Lines 144 to 145 in 217d660
|
7784bb9
to
3b59528
Compare
Reviving this PR, starting a fresh set of tests: https://github.com/spacetelescope/RegressionTests/actions/runs/12717188152 From comments on the JP ticket by David, I think we're ready to test and review this PR. |
Regression test results look mostly as expected, but there is a unit test for extract_1d (marked 'slow', so it doesn't run in CI) that failed: jwst/extract_1d/tests/test_extract_1d_step.py::test_extract_niriss_soss_96. I'm looking into it, but I haven't been able to reproduce it locally yet. Update: looks like an optimization instability for the pathological testing data. I sent in a PR to fix the test with slightly less improbable input data: #9069 |
Resolves JP-3664
Closes #8580
This draft exists to remove jwst's upper pin on numpy, as well as provides a spot to test changes to coron3 unit tests that appear to be incompatible with np2.0.
Checklist for PR authors (skip items if you don't have permissions or they are not applicable)
CHANGES.rst
within the relevant release sectionHow to run regression tests on a PR