-
Notifications
You must be signed in to change notification settings - Fork 182
JP-3967: Update test to go with stcal PR 421 changes #10036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
pllim
wants to merge
3
commits into
spacetelescope:main
Choose a base branch
from
pllim:ramp-bunctious
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10036 +/- ##
==========================================
- Coverage 85.72% 85.65% -0.07%
==========================================
Files 367 365 -2
Lines 38235 38171 -64
==========================================
- Hits 32776 32696 -80
- Misses 5459 5475 +16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
83395b8 to
10039e9
Compare
This comment was marked as resolved.
This comment was marked as resolved.
fe3f047 to
8d56ecc
Compare
This comment was marked as resolved.
This comment was marked as resolved.
cb99c3c to
0fecc21
Compare
0fecc21 to
ee68cd6
Compare
e69a5fe to
879e497
Compare
a5b34e3 to
9a40036
Compare
pixel to actually be saturated for JP-3967
for 3 tests where ramp is important
9a40036 to
6021e8b
Compare
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves JP-3967
This PR addresses #8124 and is a companion for spacetelescope/stcal#421 .
TODO
test_nirspec_picture_frame[rate]ramp.fits, which requires local runtest_niriss_image_detector1_with_likelihood[likely_rate]Note: The following uncommitted diff was necessary to decouple CHARGELOSS effect from ramp fitting in checking test results locally.
Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)docs/pagestcal@git+https://github.com/pllim/stcal.git@life-of-a-sat-grid-- https://github.com/spacetelescope/RegressionTests/actions/runs/19682955885 and https://github.com/spacetelescope/RegressionTests/actions/runs/19901568465 and https://github.com/spacetelescope/RegressionTests/actions/runs/20086800853 and https://github.com/spacetelescope/RegressionTests/actions/runs/20108700591 and https://github.com/spacetelescope/RegressionTests/actions/runs/20248199486 and https://github.com/spacetelescope/RegressionTests/actions/runs/20289156418okify_regteststo update the truth files