Skip to content

Conversation

@pllim
Copy link
Collaborator

@pllim pllim commented Nov 24, 2025

Resolves JP-3967

This PR addresses #8124 and is a companion for spacetelescope/stcal#421 .

TODO

  • Make sure CI passes.
  • Do we need change log? There is change log in the stcal PR but jwst users might not read stcal change log.
  • Verify that RT failures are expected by
    • checking test summary to ensure failures are only from DQ extensions
      • re-check test_nirspec_picture_frame[rate]
    • checking test results to ensure only saturation flag is added, and added where it is supposed to by also comparing to input ramp.fits, which requires local run
      • resolve test_niriss_image_detector1_with_likelihood[likely_rate]
  • Drop the TMP commit pointing to upstream PR branch once point is proven, and upstream PR is merged.

Note: The following uncommitted diff was necessary to decouple CHARGELOSS effect from ramp fitting in checking test results locally.

--- a/jwst/regtest/test_niriss_image.py
+++ b/jwst/regtest/test_niriss_image.py
@@ -162,6 +162,7 @@ def run_detector1_with_likelihood_fitting(rtdata_mod
ule, resource_tracker):
         rtdata_module.input,
         "--output_file=jw01094001002_02107_00001_nis_likely",
         "--steps.ramp_fit.algorithm=LIKELY",
+        "--steps.charge_migration.skip=True",
     ]
     with resource_tracker.track():
         Step.from_cmdline(args)

Tasks

@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.65%. Comparing base (1193035) to head (6021e8b).
⚠️ Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10036      +/-   ##
==========================================
- Coverage   85.72%   85.65%   -0.07%     
==========================================
  Files         367      365       -2     
  Lines       38235    38171      -64     
==========================================
- Hits        32776    32696      -80     
- Misses       5459     5475      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pllim

This comment was marked as resolved.

@pllim pllim force-pushed the ramp-bunctious branch 2 times, most recently from fe3f047 to 8d56ecc Compare November 26, 2025 21:42
@pllim

This comment was marked as resolved.

pixel to actually be saturated for JP-3967
for 3 tests where ramp is important
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant