Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document image group usage for sky matching #9080

Merged
merged 10 commits into from
Feb 20, 2025
Merged

Document image group usage for sky matching #9080

merged 10 commits into from
Feb 20, 2025

Conversation

mcara
Copy link
Member

@mcara mcara commented Jan 16, 2025 •
edited by emolter
Loading

Resolves JP-3843
Fixes #9063

This PR adds description of image groups in relation to sky matching and when grouping is desirable or not.

Tasks

  • request a review from someone specific, to avoid making the maintainers review every PR
  • add a build milestone, i.e. Build 11.3 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@mcara mcara requested a review from a team as a code owner January 16, 2025 09:27
@mcara mcara force-pushed the skymatch-grouping branch 2 times, most recently from 73d3395 to 859c5bb Compare January 16, 2025 09:42
@codecov Codecov
Copy link

codecov bot commented Jan 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.66%. Comparing base (f0aa1c1) to head (69b9f89).
Report is 8 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #9080   +/-   ##
=======================================
  Coverage   73.66%   73.66%           
=======================================
  Files         368      368           
  Lines       36391    36391           
=======================================
  Hits        26808    26808           
  Misses       9583     9583

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

emolter
emolter reviewed Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@emolter emolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic Mihai. I just added a few comments to improve grammar/clarity slightly.

@emolter emolter added this to the Build 11.3 milestone Jan 16, 2025
@mcara mcara requested a review from drlaw1558 January 16, 2025 19:45
@mcara mcara self-assigned this Jan 16, 2025
@stscijgbot-jp stscijgbot-jp mentioned this pull request Jan 27, 2025
Closed
@mcara mcara requested a review from tapastro January 31, 2025 15:57
@melanieclarke
Copy link
Collaborator

@tapastro - did you want to review this documentation change?

@mcara mcara force-pushed the skymatch-grouping branch from 7afe44e to 7f4f135 Compare February 18, 2025 20:01
mcara and others added 8 commits February 18, 2025 16:39
@mcara mcara force-pushed the skymatch-grouping branch from e4e1d5f to adc0321 Compare February 18, 2025 21:39
tapastro
tapastro approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@tapastro tapastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tapastro tapastro enabled auto-merge (squash) February 20, 2025 16:46
@tapastro tapastro merged commit fa8645c into spacetelescope:main Feb 20, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emolter emolter emolter left review comments

@tapastro tapastro tapastro approved these changes

@kmacdonald-stsci kmacdonald-stsci kmacdonald-stsci approved these changes

@drlaw1558 drlaw1558 Awaiting requested review from drlaw1558

Assignees

@mcara mcara

Labels
documentation no-changelog-entry-needed
Projects
None yet
Milestone
Build 11.3
Development

Successfully merging this pull request may close these issues.

Investigate differences between user and pipeline match algorithm in skymatch
5 participants
@mcara @melanieclarke @tapastro @emolter @kmacdonald-stsci