Skip to content

Conversation

@kecnry
Copy link
Member

@kecnry kecnry commented Nov 21, 2025

Description

This pull request extends on #3906 to add support for JWST and HST cone searches, including downloading and pulling in any data products OR treating the observation table as a source catalog (currently requires app.state.catalogs_in_dc = True)

Screen.Recording.2025-11-21.at.3.08.27.PM.mov

This should be rebased on top of #3906 and #3894 (if merged first) hooking up support for footprint visualization/selection.

    :is_wcs_linked="is_wcs_linked"
    :image_data_loaded="image_data_loaded"
    :footprint_select_icon="footprint_select_icon"
    :custom_toolbar_enabled="custom_toolbar_enabled"

TODO:

  • fix support for loading as catalog after unselecting "treat table as query"
  • decide whether to remove "MAST:" prefix (UI users likely don't care that its going through MAST Missions) and reorder so JWST and HST are on top of list?
  • test coverage

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • If new remote data is added that uses MAST, is the URI added to the cache-download.yml workflow?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry mentioned this pull request Nov 21, 2025
10 tasks
@kecnry kecnry added this to the 4.5 milestone Nov 21, 2025
@kecnry kecnry force-pushed the resolver-astroquery-mast branch 9 times, most recently from dcb64c0 to dbe9764 Compare November 26, 2025 19:08
@kecnry kecnry force-pushed the resolver-astroquery-mast branch from dbe9764 to 3cbaab2 Compare December 1, 2025 15:44
jdaviz/utils.py Outdated
Comment on lines 68 to 72
'worldra']
'worldra', 'targ_ra']
DEC_COMPS = ['declination', 'dec', 'decdeg', 'decdeg',
'decdegrees', 'declinationdegrees', 'declinationdeg',
'decobj', 'objdec', 'decsource', 'sourcedec', 'decj2000', 'dec2000',
'worlddec']
'worlddec', 'targ_dec']
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cshanahan1 - I would have expected this to do the trick to auto-populated the col_ra and col_dec dropdowns for the catalog importer. Any idea why this doesn't work?

import jdaviz as jd
jd.gca().app.state.catalogs_in_dc = True
jd.show()

ldr = jd.loaders['astroquery']
ldr.source = 'M4'
ldr.radius = 10
ldr.open_in_tray()
ldr.query_archive()

print(ldr.col_ra.selected)

Copy link
Contributor

@cshanahan1 cshanahan1 Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like you might have addressed this already by adding 'targ_dec' and 'targ_ra? it won't auto-populate unless it matches (case and delimiter insensitive) something in that list. i've been adding them as i find them from different catalog formats etc.

@kecnry kecnry force-pushed the resolver-astroquery-mast branch from 0f303b3 to 9f05168 Compare December 2, 2025 19:08
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cshanahan1 - I think some changes in here broke two of the visibility tests and might be related to your current work - any ideas?

@rosteen rosteen removed this from the 4.5 milestone Dec 15, 2025
@rosteen rosteen added this to the 4.6 milestone Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants