-
Notifications
You must be signed in to change notification settings - Fork 88
Astroquery (JWST & HST) resolver #3907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
dcb64c0 to
dbe9764
Compare
dbe9764 to
3cbaab2
Compare
jdaviz/utils.py
Outdated
| 'worldra'] | ||
| 'worldra', 'targ_ra'] | ||
| DEC_COMPS = ['declination', 'dec', 'decdeg', 'decdeg', | ||
| 'decdegrees', 'declinationdegrees', 'declinationdeg', | ||
| 'decobj', 'objdec', 'decsource', 'sourcedec', 'decj2000', 'dec2000', | ||
| 'worlddec'] | ||
| 'worlddec', 'targ_dec'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cshanahan1 - I would have expected this to do the trick to auto-populated the col_ra and col_dec dropdowns for the catalog importer. Any idea why this doesn't work?
import jdaviz as jd
jd.gca().app.state.catalogs_in_dc = True
jd.show()
ldr = jd.loaders['astroquery']
ldr.source = 'M4'
ldr.radius = 10
ldr.open_in_tray()
ldr.query_archive()
print(ldr.col_ra.selected)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like you might have addressed this already by adding 'targ_dec' and 'targ_ra? it won't auto-populate unless it matches (case and delimiter insensitive) something in that list. i've been adding them as i find them from different catalog formats etc.
0f303b3 to
9f05168
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cshanahan1 - I think some changes in here broke two of the visibility tests and might be related to your current work - any ideas?
Description
This pull request extends on #3906 to add support for JWST and HST cone searches, including downloading and pulling in any data products OR treating the observation table as a source catalog (currently requires
app.state.catalogs_in_dc = True)Screen.Recording.2025-11-21.at.3.08.27.PM.mov
This should be rebased on top of #3906 and #3894 (if merged first) hooking up support for footprint visualization/selection.TODO:
Change log entry
CHANGES.rst? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rstbefore merge. If no, maintainershould add a
no-changelog-entry-neededlabel.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
triviallabel.cache-download.ymlworkflow?