Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-menu: remove/deprecate old data menu #3281

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Nov 12, 2024

Description

This pull request removes the old data-menu and exposes the new data-menu. This keeps the old icon/button, but only shows a tooltip pointing to the new data-menu. Old API access is deprecated and points to alternatives in the new data menu API.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added this to the 4.1 milestone Nov 12, 2024
@github-actions github-actions bot added documentation Explanation of code and concepts cubeviz specviz embed Regarding issues with front-end embedding imviz plugin Label for plugins common to multiple configurations labels Nov 12, 2024
@kecnry kecnry force-pushed the dm-remove-old branch 4 times, most recently from 44a42dc to 40df2dd Compare November 18, 2024 19:56
@kecnry kecnry force-pushed the dm-remove-old branch 2 times, most recently from ae9a458 to 2afd53e Compare December 2, 2024 14:53
@kecnry kecnry force-pushed the dm-remove-old branch 2 times, most recently from dccca7e to 6dda0d5 Compare December 6, 2024 20:45
@rosteen rosteen modified the milestones: 4.1, 4.2 Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cubeviz documentation Explanation of code and concepts embed Regarding issues with front-end embedding imviz plugin Label for plugins common to multiple configurations specviz
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants