Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper API call to reset the application to a clean state #3273

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

rosteen
Copy link
Collaborator

@rosteen rosteen commented Nov 7, 2024

This adds the ability to call viz.reset_app() to completely reset the Jdaviz application to a clean state. The only outstanding issue that I'm aware of is that after resetting, creating new subsets continues to iterate from where they left off for labels and colors:

Screen.Recording.2024-11-07.at.4.45.01.PM.mov

cc @eteq

@rosteen rosteen added feature Feature request api API change labels Nov 7, 2024
@rosteen rosteen added this to the 4.1 milestone Nov 7, 2024
@eteq
Copy link
Contributor

eteq commented Nov 11, 2024

Happy to see this! out-of-band I had asked about this functionality, with a use case in mind of wanting to clear out large files from memory and reset various app details without re-creating the helper object (so that I don't have to re-show it, among other reasons).

It looks like this fully addresses my specific use case even without the subset fix. FWIW, I think if that's going to be a significantly heavier lift to do the subset part, it might be fine to merge this functionality with that limitation (as long as it's noted in the docs) and have a longer-running issue to address that last bit.

@rosteen rosteen modified the milestones: 4.1, 4.2 Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API change feature Feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants