Add support for co-adding with squared weights #163
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #163 +/- ##
==========================================
+ Coverage 97.27% 99.66% +2.39%
==========================================
Files 3 2 -1
Lines 220 300 +80
==========================================
+ Hits 214 299 +85
+ Misses 6 1 -5 ☔ View full report in Codecov by Sentry. |
mcara
force-pushed
the
add-resampling-with-square-weights
branch
from
5282430 to
cf658bf
Compare
… style improvements
mcara
force-pushed
the
add-resampling-with-square-weights
branch
3 times, most recently
from
568b72e to
b2c4529
Compare
mcara
force-pushed
the
add-resampling-with-square-weights
branch
from
b2c4529 to
8690bee
Compare
mcara
force-pushed
the
add-resampling-with-square-weights
branch
from
bef3e11 to
918ca73
Compare
|
|
||
| self._out_img2 = [] | ||
|
|
||
| if (isinstance(self._fillval2, str) and |
There was a problem hiding this comment.
I recommend putting the and at the beginning of the next line, rather than at the end of a line, to make it easier to see.
| del arr | ||
|
|
||
| def _alloc_output_arrays2_add(self, ninputs2=None): | ||
| if (isinstance(self._fillval2, str) and |
There was a problem hiding this comment.
I recommend putting the and at the beginning of the next line to make it more visible.
| dtype=np.float32 | ||
| ) | ||
|
|
||
| if ((ninputs2 is not None and ninputs2 != nimg2) or |
There was a problem hiding this comment.
I recommend moving the or to the beginning of the next line to make it more visible.
| @@ -48,16 +48,160 @@ scale_image(PyArrayObject *image, double scale_factor) { | |||
| * Top level function for drizzling, interfaces with python code | |||
| */ | |||
|
|
|||
| static int | |||
| process_array_list(PyObject *list, integer_t *nx, integer_t *ny, | |||
There was a problem hiding this comment.
Add comment to document what this function does, as well as what the function parameters are.
| Py_XDECREF(arr_list[i]); | ||
| } | ||
| free(arr_list); | ||
| } |
There was a problem hiding this comment.
Needs a return value.
| free(arr_list); | ||
| } | ||
| } | ||
|
|
||
| static PyObject * | ||
| tdriz(PyObject *obj UNUSED_PARAM, PyObject *args, PyObject *keywords) { |
There was a problem hiding this comment.
This function roughly 400 lines long and should be broken down into smaller sub-functions.
| @@ -228,47 +536,38 @@ tdriz(PyObject *obj UNUSED_PARAM, PyObject *args, PyObject *keywords) { | |||
| p.exposure_time = expin; | |||
| p.weight_scale = wtscl; | |||
| p.fill_value = fill_value; | |||
| p.fill_value2 = fill_value2; | |||
There was a problem hiding this comment.
One letter variable names should be avoided for things other than indices. I recommend changing p to a more descriptive variable name.
This PR adds support for resampling and adding resampled (error, variance) images with squared weights. This is to facilitate standard error propagation.