-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use astropy pixel_to_pixel in calc_pixmap #161
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #161 +/- ##
===========================================
+ Coverage 75.29% 97.28% +21.99%
===========================================
Files 7 3 -4
Lines 344 221 -123
===========================================
- Hits 259 215 -44
+ Misses 85 6 -79 ☔ View full report in Codecov by Sentry. |
99d15a7
to
6f81c3c
Compare
6f81c3c
to
8affa48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I guess I had the thought when I opened the issue that it would completely replace calc_pixmap
, but I see that one still needs to bundle it into a pixmap that the drizzle C code can use. Bummer.
Anyway, looks good. Hopefully jwst.resample
can now use the calc_pixmap
function here. I recall it had been copied over to jwst.resample
because for along time the one here did not support gwcs
and APE 14 did not exist.
👍
This will need careful consideration, and as a minimum a regression test run. Looking at the astropy |
There are unit tests testing |
Closes #51