Refactor synchronization structure #263
Open
+433
−287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehpor
force-pushed
the
refactor/synchronization
branch
3 times, most recently
from
ba45577 to
5617db8
Compare
It should only be around the tme-critical part.
This allows us to separate different types of synchronization within one operating system.
ehpor
force-pushed
the
refactor/synchronization
branch
from
5617db8 to
e8d00f0
Compare
|
I am looking at it, but I am trying to familiarize myself with those concepts before approving |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the synchronization methods inside data streams. This makes it easier to add multiple types of synchronization per operating system.
The proposed system uses the CRTP (Curiously recurring template pattern) instead of compiler pre-directives. This makes it possible, at no runtime cost, to choose the synchronization method. This PR just adds the synchronization methods that were already implemented.
Larger scale goal is to bring catkit2 data streams closer to ImageStreamIO data streams.
This PR does not intend to change any existing code, just reorder/reformat/move it to allow for a more modular structure.