Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base classes for cameras #131

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from
Draft

Add base classes for cameras #131

wants to merge 6 commits into from

Conversation

ehpor
Copy link
Collaborator

@ehpor ehpor commented Oct 24, 2023

WIP but I might want some feedback soon.

These base services generalize much of the functionality that is currently duplicated between cameras and DMs. This simplifies their implementation and makes fixing bugs in ROI flips and rotations, DM channel updates, etc. much easier in the future.

@ehpor ehpor added the refactor Refactor existing code. label Oct 24, 2023
@ehpor
Copy link
Collaborator Author

ehpor commented Oct 24, 2023

@ivalaginja This might be interesting for you. I mainly want to know if the Andor camera is compatible with this base class.

@ehpor ehpor marked this pull request as draft October 24, 2023 05:20
@ivalaginja
Copy link
Collaborator

@ehpor this looks totally compatible with our Andor Neo. I don't think we'd have some of the parameters to read from the config, like the gain, but we can keep those properties unimplemented and the value in the configfile at None or empty so that it just sets the default value, considering it would never use it anyway.

@ehpor ehpor mentioned this pull request Nov 12, 2023
8 tasks
@raphaelpclt raphaelpclt changed the title Add base classes for cameras and DMs Add base classes for cameras Oct 2, 2024
@ivalaginja
Copy link
Collaborator

Just a note: the DM base classes have now been merged in #156, so anything DM in this PR can simply be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor existing code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants