-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix datastream lifetime. #112
base: develop
Are you sure you want to change the base?
Conversation
I was mistaken in my original thinking that this was a bug. However, this PR still adds error messages that will more clearly indicate errors in the future. In addition, this PR adds a test for datastream lifetime, which ensures that we do not deviate from the current expected behaviour. This will catch any bugs when rewriting parts of the datastream code in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @ehpor, I have not run the test myself, but that sounds like a great idea to add that in case there is a problem later, especially in light of the recent issues we found on CI that are really had to debug without any additional info.
cdc1f07
to
a55382a
Compare
We need to test this more extensively, so I don't want to merge accidentally
8238e5a
to
9bbc173
Compare
This PR is for a potential bug in data stream lifetime.(see comment below)Fixes #113.