Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support a more secure security-context #76

Merged
merged 1 commit into from
Sep 17, 2024
Merged

feat: support a more secure security-context #76

merged 1 commit into from
Sep 17, 2024

Conversation

Apollorion
Copy link
Member

@Apollorion Apollorion commented Sep 17, 2024 •
edited
Loading

Added a more secure/best practice security context to the promex container. It will allow customers to set the Pod Security Policy to restricted.

  • A chart version is updated
    • No changes on CRDs
    • CRDs are updated

@Apollorion Apollorion requested a review from a team as a code owner September 17, 2024 14:30
@Apollorion Apollorion requested a review from a team September 17, 2024 14:32
Apollorion
Apollorion commented Sep 17, 2024
View reviewed changes
spacelift-promex/templates/deployment.yaml
runAsNonRoot: true
seccompProfile:
type: "RuntimeDefault"
runAsUser: 1983
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the UID of the spacelift user here.

@Apollorion Apollorion merged commit 020bdb9 into main Sep 17, 2024
1 check passed
@Apollorion Apollorion deleted the security-context branch September 17, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamconnelly adamconnelly adamconnelly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Apollorion @adamconnelly