docker-init: handle linux init responsibilities #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dockerd doesn't handle PID1 responsibilities well, this PR delegates these to docker-init to ensure that all zombie child processes are reaped etc.
mbialon
approved these changes
Apr 4, 2023
|
Is someone able to help me with a merge on this PR plz? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dockerddoesn't handle PID1 responsibilities well.Upstream issue:
docker-library/docker#318
Blog description:
https://blog.phusion.nl/2015/01/20/docker-and-the-pid-1-zombie-reaping-problem/
Given that we aren't on the latest version of
dind, and we don't use the native entry point wrapper, we should add this logic to ensure that process reaping occurs as expected.Local testing:
https://gist.github.com/lexton/f7684b70ce7ca2f090490ded9ff1b9ad