CLI: all responses are displayable in JSON #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keksoj
force-pushed
the
fix-display-in-json-form
branch
2 times, most recently
from
8c909ec to
8c5e442
Compare
|
plus a big refactor: remove the display logic from the This removes about a hundred lines of boilerplate, and makes everything more readable. |
Keksoj
force-pushed
the
fix-display-in-json-form
branch
3 times, most recently
from
b5c3595 to
2ba80a2
Compare
Keksoj
force-pushed
the
fix-display-in-json-form
branch
2 times, most recently
from
c193757 to
97b4f01
Compare
Keksoj
force-pushed
the
fix-display-in-json-form
branch
2 times, most recently
from
f0ba2cd to
88fb8cb
Compare
FlorentinDUBOIS
approved these changes
Dec 6, 2023
Keksoj
force-pushed
the
fix-display-in-json-form
branch
from
88fb8cb to
86303a2
Compare
remove bin/cli/display.rs since it is ported add json field to CommandManager add global json option to CLI arguments put certificate loading functions in certificate module
so that the output of --json commands is pipeable
display "no cluster found" if response is empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some CLI commands would not display responses in a JSON format with the
--jsonoption.This PR makes the
--jsonoption global and ensures all responses are displayable in JSON.