Skip to content

Conversation

@thug-gamer
Copy link

@thug-gamer thug-gamer commented Oct 14, 2025

Description

This pull request enables support for IMDSv2 by updating the aws-sdk-core to ~> 3.126.2
This version was chosen since it includes

  1. the introduction of the new class EC2Metadata (3.111.0)
  2. the usage of the class in default configuration (3.125.0)
  3. a bug fix related to expired tokens used in IMDS (3.126.1)

Issues Resolved

Check List

  • A conventional commit message
    This triggers our CHANGELOG and release pipeline (release-please); without your change, it cannot be released.
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

@thug-gamer thug-gamer requested a review from a team as a code owner October 14, 2025 17:31
@thug-gamer
Copy link
Author

The checks are failing because I am not allowed to modify the metadata.rb

@damacus
Copy link
Member

damacus commented Oct 15, 2025

Yes, please undo the metadata change, the release job will manage that for us 👍🏼

The rest of the PR looks great.

@thug-gamer thug-gamer force-pushed the feat/support-imdsv2 branch 3 times, most recently from a0271b8 to a8c5779 Compare October 15, 2025 17:41
@thug-gamer
Copy link
Author

thug-gamer commented Oct 15, 2025

Thanks @damacus. I rebased the PR and removed my metadata.rb changes. Does it look good now (although I don't understand how the release job will update the dependency)?

@damacus
Copy link
Member

damacus commented Oct 15, 2025

Maybe I'm missing something but I don't see the update anymore?

Also sorry to be nit picky. You don't need to update the changelog anymore,the release pipeline will take care of it for you!

Sorry it's only been in a day 😂

@thug-gamer
Copy link
Author

Thanks for the quick feedback. I removed the changelog entry and re-added my change. The issue however is that my change needs to happen inside the metadata.rb (dependency update).
How do we proceed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants