Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely on pyright import resolution for module names #139

Draft
wants to merge 6 commits into
base: scip
Choose a base branch
from

Conversation

Titou325
Copy link
Contributor

@Titou325 Titou325 commented Nov 24, 2023

This is a first step towards fixing #133, there are still some cases that need to be verified (use of Symbols.makeModuleInit).

This fixes the cases previously mentioned.

Notes:

  • When checking if resolvedPaths is not empty, we need to fetch the last resolvedPath element rather than the first one.
  • This may break for unresolved imports? Need to add more test cases.
  • This uses a private function. It could be accessible from other functions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant