Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change icons for batch select in the panel grid (the white circles) more visible #302

Open
HannahSonntag opened this issue Jan 19, 2022 · 5 comments
Assignees

Comments

@HannahSonntag
Copy link
Collaborator

Currently the white circles are invisible on white background.
Rather use a gray-transparent circle turning opaque when active. (Similar to google photo)

eidens added a commit that referenced this issue Jan 20, 2022
eidens added a commit that referenced this issue Jan 20, 2022
Should an image now have the same color as one of the two, the other is
still visible.

[Issue: #302]
@eidens
Copy link
Member

eidens commented Jan 20, 2022

The panel select button should now be much more visible on white images as it's now filled with a light and slightly transparent grey that is different from the border color. Even on images with the same color as one of background or border, the other one is still visible.

@eidens eidens assigned HannahSonntag and unassigned eidens Jan 20, 2022
@HannahSonntag
Copy link
Collaborator Author

I like the visibility, it's much better now.
But I find the select button looks goofily big now. Can we reduce the size? Something like 50% almost?

eidens added a commit that referenced this issue Jan 21, 2022
@eidens
Copy link
Member

eidens commented Jan 21, 2022

The buttons are now around half as wide as before.

@HannahSonntag
Copy link
Collaborator Author

While these are much better visible now, we would like them to be more like the ‘google photo’ thing. But since not alle SmartFigures on a users Dashboard are selectable to the user, it is has to become clear to the user, why certain SmartFigures cannot be selected.
Therefore: When hovering over the SmartFigure there should be a ‘shadow’ covering the top bit of the Smartfigure (as in google photo) and the ‘select’ button is then clearly visible- regardless of the image color. But for panels that one cannot select, there will be no select icon. But instead a ‘conditional tool tip’ informing the user ‘you are not the owner’.

@HannahSonntag
Copy link
Collaborator Author

Edit: the icons in the lower right corner (sharing status) are also rather difficult to see and in the user testing everyone overlooked them.
So the 'shadow' when hovering over the image could also extend over these icons to make them more visible -regardless of the image background color.

eidens added a commit that referenced this issue Feb 16, 2022
eidens added a commit that referenced this issue Feb 16, 2022
eidens added a commit that referenced this issue Feb 16, 2022
eidens added a commit that referenced this issue Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants