This repository has been archived by the owner on Oct 3, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create preprocessing_script.sh #1303
base: master
Are you sure you want to change the base?
create preprocessing_script.sh #1303
Changes from 3 commits
1ba8107
7459dc5
93d3ec5
f7d83f7
5e855fd
537c756
845ed34
f97f795
38da6fc
74d7330
797951c
da58f2f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Can't this logging and
continue
action just simply happen in the default case of thecase
instruction? This would simplify the code, no need to check for the content of"$property_file"
, so readability would be improvedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: make sure that the files really contain a main function
Context: Unfortunately not all of those c files seem to contain a main function. For example for CWE191 I found 418 .c files mentioning "main" and 198 without that:
For verification tasks I think we need a main function. Those seem to be all which end in
[0-9a].c
. Those that end in[b-z].c
seem to be the ones without main function. At least in this folder at which I looked.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: why do we need to omit the good code for generating the "bad" tasks? Couldn't we just leave that code in there or maybe have two versions of the bad code, one with the good behavior still there and one without it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: determine whether preprocessing actually succeeded and only write a yml file in this case, i.e., if the return code is 0.