Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single conversion format e.g "$400". & Add a more relevant API error message #18

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Single conversion format e.g "$400". & Add a more relevant API error message #18

wants to merge 4 commits into from

Conversation

mattlennon3
Copy link

image

image

Happy to adjust the messaging for the 429 error. It would be nice to point the user towards setting the API key themselves. Perhaps via a field in the Alfred GUI?

@mattlennon3
Copy link
Author

Removed my update to the README for the API key setup. As this other PR has done a better job.

Though I think their changes to lines 33/34 of currency.php are no longer needed because of my changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mattlennon3