Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid querying route53 with empty leading labels #65

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

sorah
Copy link
Owner

@sorah sorah commented Dec 4, 2024

FATAL problem: DomainLabelEmpty (Domain label is empty) encountered with 'example.org..' (Aws::Route53::Errors::InvalidInput)

Formerly we had no problem, but Route53 may changed its behaviour to reject queries including such invalid names (empty labels).

@sorah sorah enabled auto-merge December 4, 2024 20:21
@sorah sorah force-pushed the route53-rej-root-label-list branch from 39fe532 to 60a98ae Compare December 4, 2024 22:02
sorah added 2 commits December 5, 2024 07:03
    FATAL problem: DomainLabelEmpty (Domain label is empty) encountered with
    'example.org..' (Aws::Route53::Errors::InvalidInput)

  Formerly we had no problem, but Route53 may changed its behaviour to
  reject queries including such invalid names (empty labels).
@sorah sorah force-pushed the route53-rej-root-label-list branch from 60a98ae to e787001 Compare December 4, 2024 22:03
@sorah sorah changed the title ListResourceRecordSets now rejects name ending '.' avoid querying route53 with empty leading labels Dec 4, 2024
@sorah sorah merged commit 88bb295 into master Dec 4, 2024
8 checks passed
@sorah sorah deleted the route53-rej-root-label-list branch December 4, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant