Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix enum sequence and struct sequence validation #412

Merged
merged 5 commits into from
Oct 14, 2024
Merged

Fix enum sequence and struct sequence validation #412

merged 5 commits into from
Oct 14, 2024

Conversation

jonathan-r-thorpe
Copy link
Contributor

  • Enum sequences and struct sequences are failing the constraint validation even though they were valid.
  • This is because the enum and struct sequences were not being treated like arrays.
  • This PR fixes the problem.
  • It also includes improved logging/error reporting.
  • The draft MS-05-02 test suite in NMOS Testing has been updated to trap this bug.

lo-simon
lo-simon requested changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@lo-simon lo-simon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest minor changes. Rest LGTM.

Development/nmos/control_protocol_methods.cpp Outdated Show resolved Hide resolved
Development/nmos/control_protocol_methods.cpp Outdated Show resolved Hide resolved
Development/nmos/control_protocol_methods.cpp Outdated Show resolved Hide resolved
Development/nmos/control_protocol_methods.cpp Outdated Show resolved Hide resolved
Development/nmos/control_protocol_methods.cpp Outdated Show resolved Hide resolved
Development/nmos/control_protocol_methods.cpp Outdated Show resolved Hide resolved
Development/nmos/control_protocol_methods.cpp Outdated Show resolved Hide resolved
Development/nmos/control_protocol_methods.cpp Outdated Show resolved Hide resolved
Development/nmos/control_protocol_methods.cpp Outdated Show resolved Hide resolved
Development/nmos/control_protocol_utils.cpp Outdated Show resolved Hide resolved
@lo-simon lo-simon merged commit 7a264e9 into master Oct 14, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garethsb garethsb garethsb left review comments

@lo-simon lo-simon lo-simon requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathan-r-thorpe @lo-simon @garethsb