Fix openssl3 deprecated functions

[lo-simon]

No description provided.

[garethsb]

Would it be possible to use a EVP_PKEY_ptr here and avoid the explicit EVP_PKEY_free calls below?

[lo-simon]

Yes I had the same thought, but couldn't think how it could be done

[lo-simon]

Done using the boost.ASIO cleanup-struct idiom

[garethsb]

In this function is there no difference in control flow, only the difference between these two snippets?

OpenSSL <3.0

            RSA_ptr rsa(EVP_PKEY_get1_RSA(private_key.get()), &RSA_free);
            if (!rsa)
            {
                throw jwk_exception("extract public key error: failed to load RSA key from private key");
            }
            if (bio && PEM_write_bio_RSA_PUBKEY(bio.get(), rsa.get()))

OpenSSL >=3.0

            if (bio && PEM_write_bio_PUBKEY(bio.get(), private_key.get()))

[lo-simon]

yes, you are right, let's change it

[lo-simon]

Fixed

[garethsb]

@lo-simon I can't remember, was this cleanup-struct idiom adopted from the Boost.ASIO code?
It serves the same purpose as your usage of std::unique_ptr in nmos/jwk_utils.cpp, is that right?

[lo-simon]

yes, it is; see the following example extracted from asio\ssl\impl\contentext.ipp

struct context::bio_cleanup
{
  BIO* p;
  ~bio_cleanup() { if (p) ::BIO_free(p); }
};

struct context::x509_cleanup
{
  X509* p;
  ~x509_cleanup() { if (p) ::X509_free(p); }
};

struct context::evp_pkey_cleanup
{
  EVP_PKEY* p;
  ~evp_pkey_cleanup() { if (p) ::EVP_PKEY_free(p); }
};

#if (OPENSSL_VERSION_NUMBER < 0x30000000L)
struct context::rsa_cleanup
{
  RSA* p;
  ~rsa_cleanup() { if (p) ::RSA_free(p); }
};

struct context::dh_cleanup
{
  DH* p;
  ~dh_cleanup() { if (p) ::DH_free(p); }
};
#endif // (OPENSSL_VERSION_NUMBER < 0x30000000L)

[garethsb]

@lo-simon Is this tested in CI with both OpenSSL 3.0+ and with OpenSSL 1.1.1?

[lo-simon]

@lo-simon Is this tested in CI with both OpenSSL 3.0+ and with OpenSSL 1.1.1?

We kept Ubuntu14.04 to use OpenSSL 1.0.1f, so CI tests <OpenSSL 3.0 too