IS-12 support #330
Merged
IS-12 support #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maweit
reviewed
May 12, 2023
maweit
reviewed
May 12, 2023
maweit
reviewed
May 12, 2023
maweit
reviewed
May 12, 2023
maweit
reviewed
Aug 4, 2023
maweit
reviewed
Aug 4, 2023
Add callback to retrieve control classes from control_protocol_state
Co-authored-by: jonathan-r-thorpe <[email protected]>
Co-authored-by: jonathan-r-thorpe <[email protected]>
Co-authored-by: jonathan-r-thorpe <[email protected]>
garethsb
reviewed
Mar 15, 2024
| BST_REQUIRE_THROW(nmos::details::constraints_validation(value::string(U("1a2")), value::null(), value::null(), with_constraints_string_constraints_validation_params), nmos::control_protocol_exception); | ||
| BST_REQUIRE_THROW(nmos::details::constraints_validation(value::string(U("1*")), value::null(), value::null(), with_constraints_string_constraints_validation_params), nmos::control_protocol_exception); | ||
| const nmos::details::datatype_constraints_validation_parameters no_constraints_string_constraints_validation_params{ no_constraints_string_datatype, nmos::make_get_control_protocol_datatype_descriptor_handler(control_protocol_state) }; | ||
| BST_REQUIRE_NO_THROW(nmos::details::constraints_validation(value::string(U("1234567890-abcde-!\"�$%^&*()_+=")), value::null(), value::null(), no_constraints_string_constraints_validation_params)); |
There was a problem hiding this comment.
@lo-simon, @jonathan-r-thorpe, strings with the '£' character in are causing warnings:
illegal character encoding in string literal [-Winvalid-source-encoding]
The £ character doesn't appear in 7-bit ASCII. It's U+00A3 in Unicode, so it's fine in a wchar_t string literal on Windows, and actually also in Windows-1252 codepage strings... but in UTF-8 it would be the two octets C2 A3.
Do you need to test this character specifically?
There was a problem hiding this comment.
I don't think we need to specifically test this character. Let's just remove the '£/�' from the string.
There was a problem hiding this comment.
Yes, the £ character can be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the basic WebSocket server for IS-12