Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support external libraries #11

Merged
merged 14 commits into from
Mar 22, 2021
Merged

Support external libraries #11

merged 14 commits into from
Mar 22, 2021

Conversation

someguy20336
Copy link
Owner

@someguy20336 someguy20336 commented Mar 19, 2021

I am assuming it fixes all of the following considering I strongly suspect they are all trying to pull documentation from external libraries.

TODOs

  • PullThroughInfo TODOs (break SyntaxNode dependency probably)
  • probably more unit tests
  • Can I better support external .Net libraries? The xmls don't seem to live with the dlls
  • Test with VS
    • Note, this isn't working well
    • The fix doesn't show up under the quick actions. BUT it does evaluate when trying to execute another quick action.
    • My best guess is that when generating quick actions, that is run in one thread that doesn't support documentation
    • But when evaluating another fix, it is run in visual studio
    • But I cannot find ANY documentation for this.
  • Make a new issue to consolidate and document some of the issues with using external libraries (commented below). However, probably close it since it doesn't seem work fixing? (issue created Outstanding Problems with external libraries #12 )
  • Do I need that custom file doc provider? I dont think so
  • up version
  • document in readme

@someguy20336 someguy20336 self-assigned this Mar 19, 2021
@someguy20336
Copy link
Owner Author

@someguy20336 someguy20336 merged commit a97803f into master Mar 22, 2021
@someguy20336 someguy20336 deleted the external-refs branch March 22, 2021 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant