This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
Update outdated README.md factory example #331
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These factories were recently moved when making the extension complaint to solidus_dev_support: - solidusio@f9dc06d
RyanofWoods
force-pushed
the
ryanofwoods/fix-outdated-readme
branch
from
84d6acf
to
d377d3e
Compare
|
I think it would be good to say that this file moved in the changelog @kennyadsl as it will cause tests to fail for developers. |
|
Pending - I actually don't think this the way we want users to include extension's factories anymore. Also, this is outdated: |
|
@RyanofWoods you are right, what about fixing it in this same PR? |
|
Can do @kennyadsl. I will investigate this more this week 🙂 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
These factories were recently moved when making the extension complaint to solidus_dev_support:
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed (
cross them outif they are not):- [ ] I have added automated tests to cover my changes.- [ ] I have attached screenshots to demo visual changes.- [ ] I have opened a PR to update the guides.- [ ] I have updated the README to account for my changes.