[Admin] Create and update tax rates#6298
Draft
chaimann wants to merge 16 commits intosolidusio:mainfrom
Draft
Conversation
github-actions
bot
added
changelog:solidus_core
chaimann
force-pushed
the
admin-tax-rates-crud
branch
from
253c4db to
186a53b
Compare
chaimann
force-pushed
the
admin-tax-rates-crud
branch
2 times, most recently
from
e806679 to
7058c2c
Compare
This will allow to clean up existing forms and write more concise forms in the future. Custom form builder encapsulates all the calls to "render", "component()" initializations, and assumes some defaults, e.g. if "checked" is not passed to "f.checkbox" we get it by calling @object.send(method)
Display table cells as links to edit tax rate. Since "zone" is an optional association, added support when zone is not present on the record.
chaimann
force-pushed
the
admin-tax-rates-crud
branch
2 times, most recently
from
1cf788b to
151b817
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6298 +/- ##
==========================================
+ Coverage 86.65% 92.91% +6.26%
==========================================
Files 521 417 -104
Lines 11943 8342 -3601
==========================================
- Hits 10349 7751 -2598
+ Misses 1594 591 -1003 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Put relevant paths for solidus admin pages
chaimann
force-pushed
the
admin-tax-rates-crud
branch
from
151b817 to
d485f9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Blocked by #6294
Summary
Adds interface to create and update Tax Rates
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs: