-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Admin][Users]Add new admin store_credits show page #5978
[Admin][Users]Add new admin store_credits show page #5978
Conversation
84f5e6f
to
7269173
Compare
The admin store credit flow is complicated enough and has enough of its own actions that it should really be in its own controller rather than squished into the users controller.
If a store credit has been invalidated it will show a red badge, if it has not, it will show a green badge. This is more in line with expectations than the previous colour scheme.
The store credits flow is in the process of being significantly refactored so this will eventually be a page which both displays the store credit info and allows editing (when appropriate). It will match the flow of the new user addresses page.
7269173
to
97919a8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5978 +/- ##
==========================================
+ Coverage 87.81% 89.47% +1.65%
==========================================
Files 476 784 +308
Lines 11656 18038 +6382
==========================================
+ Hits 10236 16139 +5903
- Misses 1420 1899 +479 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The links don't work with the specs as they blow away the query params, something which the specs expect to be present after clicking through. Since we still haven't solved that (without javascript) I think we'll need to keep it as is until we have a solution to preserve those params. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tabled #6014 (comment)
so this is ready to be merged. Thanks for the patience 🙏🏻
No worries, thank you so much for investing the time to look into it! |
Summary
This PR is for issue: #5824
The store credits flow is in the process of being significantly refactored so this will eventually be a page which both displays the store credit info and allows editing (when appropriate). It will match the flow of the new user addresses page. For now this just replaces the legacy show page and migrates the
users/:user_id/store_credits/:id
page from the legacysoldius_backend
to the newsolidus_admin
. Again there were no designs so I just tried my best to match to the existing components and layouts.Screenshots
New page
Old page
Bonus
New badge scheme
Old badge scheme
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: