Fixed vitest templates #115
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'registerNodeLoader' on true wouldn't let the tests run successfully, not in this version, nor in newer. It also is necessary to have it explicitly on false, or else, the tests wouldn't work either. Besides it doesn't log any warning on dependency duplicity, like it does in other cases, so I also removed the comment that said that.
|
I tried adjusting the |
Contributor
|
This is because vite-plugin-solid overwrites a few settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'registerNodeLoader' on true wouldn't let the tests run successfully, not in this version, nor in newer. It also is necessary to have it explicitly on false, or else, the tests wouldn't work either.
Besides it doesn't log any warning on dependency duplicity, like it does in other cases, so I also removed the comments that said that.