-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(translation): Add spanish UI translations #762
Conversation
|
✅ Deploy Preview for solid-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@royeden Thanks Roy for the update! I've asked around, and would like to inform you why this has been appearing to take a bit of time. The docs site was made with translations/localizations in mind, but then it was restructured to include SolidStart, SolidRouter and SolidMeta. This caused mayor changes to the localizations' logic, such switching languages between pages of the different subprojects and the like. It's on the works but will require some time to get it done as it was before. |
I'm going to close this PR as it is quite behind where the current docs are (which is our fault, not yours). If you'd like to continue assisting with the Spanish translations, we'd love to have a conversation about this for the new infra! |
@LadyBluenotes no problem, let me know about how this impacts the new infra and I'll go and make the translations 😄 |
@jer3m01 do you mind providing some insight into how SolidBase will be doing i18n? |
Adds generic spanish translations. Generic implies that spanish speakers will understand them, regardless of their regional variant.
This should provide a base for future spanish translations, where regional variants have different words to refer to different concepts (in case that is needed).
Comment regarding code: If english is the default, and the keys have to match, it could be good to match the
type
of translation dictionaries to match the keys in the english dictionary.Notes on translations: