You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is the follow up from a conversation in the discord, where someone tested the behavior of createEffect and found it wasn't batched. This PR addresses the confusion by documenting when createEffect is automatically batched, and when it isn't. It also adds another piece of information I felt was missing from the batch docs, namely the expected behavior when setting and then accessing a signal within a batch. This behavior used to be different pre-v1.4 which makes it additionally useful as a documentation of a breaking change.
In summary, this PR clarifies:
createEffect is not batched outside root / at top level
the expected behavior when eagerly accessing signals set within the same batch (prior to v1.4 this returned the old value, this is not longer the case)
hey @titoBouzout , I lost track of this convo. What came out of it?
Top level effects aren't batched, regular effects are batched. The idea was to batch them all to make them consistent. While the change is welcome solidjs/solid#2107 this probably will take effect on solid 2.0 to avoid unnecessary behavior changes, which sounds like a sensible option and this pr could probably be reviewed I guess
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mosheduminer
force-pushed
the
add-batch-details
branch
from
atilafassina
force-pushed
the
add-batch-details
branch
from
This PR is the follow up from a conversation in the discord, where someone tested the behavior of
createEffectand found it wasn'tbatched. This PR addresses the confusion by documenting whencreateEffectis automaticallybatched, and when it isn't. It also adds another piece of information I felt was missing from thebatchdocs, namely the expected behavior when setting and then accessing a signal within abatch. This behavior used to be different pre-v1.4 which makes it additionally useful as a documentation of a breaking change.In summary, this PR clarifies:
createEffectis not batched outside root / at top level