Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): bump typescript from 5.5.3 to 5.7.3 in /clients/js #96

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 21, 2025

Bumps typescript from 5.5.3 to 5.7.3.

Release notes

Sourced from typescript's releases.

TypeScript 5.7.3

For release notes, check out the release announcement.

Downloads are available on npm

TypeScript 5.7

For release notes, check out the release announcement.

Downloads are available on:

TypeScript 5.7 RC

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

TypeScript 5.7 Beta

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

TypeScript 5.6.3

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

... (truncated)

Commits
  • a5e123d Update LKG
  • 8bc0204 🤖 Pick PR #60828 (Fix CodeQL configuration, releases) into release-5.7 (#60923)
  • 7aa63df 🤖 Pick PR #60393 (Don't try to add an implicit undefi...) into release-5.7 (#...
  • 9df7c36 Bump version to 5.7.3 and LKG
  • e167412 🤖 Pick PR #60794 (Harden sanitizeLog against incorr...) into release-5.7 (#...
  • 9ba364c Fix coverage build on release-5.7 (#60792)
  • 4b7441a 🤖 Pick PR #60680 (Mark the inherited any-based index ...) into release-5.7 (#...
  • e844dc3 Cherry-pick #60402, #60440, #60616 into release-5.7 (#60777)
  • 21b02a1 🤖 Pick PR #60749 (Do not require import attribute on ...) into release-5.7 (#...
  • b82fd16 🤖 Pick PR #60576 (Avoid incorrectly reusing assertion...) into release-5.7 (#...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jan 21, 2025
@github-actions github-actions bot enabled auto-merge (squash) January 21, 2025 20:23
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/clients/js/typescript-5.7.3 branch 9 times, most recently from 33b273c to e710030 Compare January 22, 2025 11:02
@joncinque
Copy link
Contributor

@lorisleiva not urgent at all, but can you take a look at the issue? It looks like it's complaining because of unused code in the generated clients after compilation. Should we add a typescript flag to ignore this or fix it in the code generation? Or something else that I'm missing?

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/clients/js/typescript-5.7.3 branch 2 times, most recently from 45d2649 to 6c19a4f Compare January 23, 2025 11:42
@lorisleiva
Copy link
Member

Oh... that's annoying. I know exactly why this warning is there and I've wanted to fix it for a while now so it might be a good time to do it now that TS is getting stricter on that. Might not be for a little while though unless it's urgent.

@joncinque
Copy link
Contributor

Definitely not urgent, I just wanted you to be aware of it. Thanks!

@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/clients/js/typescript-5.7.3 branch 2 times, most recently from e0e1e1a to 6c87472 Compare January 24, 2025 10:35
@lorisleiva lorisleiva self-assigned this Jan 24, 2025
Bumps [typescript](https://github.com/microsoft/TypeScript) from 5.5.3 to 5.7.3.
- [Release notes](https://github.com/microsoft/TypeScript/releases)
- [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release.yml)
- [Commits](microsoft/TypeScript@v5.5.3...v5.7.3)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/clients/js/typescript-5.7.3 branch from 6c87472 to 6bf3262 Compare January 27, 2025 09:53
@lorisleiva
Copy link
Member

Turns out the issue was not that TypeScript decided to error on that warning but simply that dependabot didn't do a great job at upgrading the lock file.

A simple rm -rf node_modules pnpm-lock.yaml && pnpm install fixed the issue.

The reason it looked like an error on the warning is because of the lack of verbosity on the new version of zx so I added $.verbose = true to be as verbose as version 7 of zx.

I'd still like to remove that warning on Codama since it's really annoying but at least this is no longer a blocker for this PR. 🙂

@github-actions github-actions bot merged commit f380f8c into main Jan 27, 2025
20 checks passed
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/clients/js/typescript-5.7.3 branch January 27, 2025 17:43
@joncinque
Copy link
Contributor

Thanks for looking into it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants