-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[js-legacy] Add confidential transfer InitializeMint
and UpdateMint
#61
[js-legacy] Add confidential transfer InitializeMint
and UpdateMint
#61
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly tiny things, looks good overall!
clients/js-legacy/src/extensions/confidentialTransfer/actions.ts
Outdated
Show resolved
Hide resolved
clients/js-legacy/src/extensions/confidentialTransfer/elgamal.ts
Outdated
Show resolved
Hide resolved
clients/js-legacy/src/extensions/confidentialTransfer/instructions.ts
Outdated
Show resolved
Hide resolved
confidentialTransferMintAuthority = Keypair.generate(); | ||
autoApproveNewAccounts = true; | ||
auditorKeypair = ElGamalKeypair.newRand(); | ||
auditorPubkey = PodElGamalPubkey.encode(auditorKeypair.pubkey_owned()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit for zk-sdk: the function should be called pubkeyOwned()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I realized that. It is fixed in anza-xyz/agave#4315.
…ons to js-legacy client
Co-authored-by: Jon C <[email protected]>
496da81
to
925ce21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
…pdateMint` (solana-program#61)" This reverts commit c0c98ee.
…pdateMint` (solana-program#61)" This reverts commit c0c98ee.
Problem
The confidential transfer extension has not been added to the js-legacy client yet.
Summary of Changes
The confidential transfer extension will be added to the js client in a sequence of PRs. In this PR, the
InitializeMint
andUpdateMint
instructions are added.