Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[js-legacy] Add confidential transfer InitializeMint and UpdateMint #61

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

samkim-crypto
Copy link
Contributor

@samkim-crypto samkim-crypto commented Jan 13, 2025

Problem

The confidential transfer extension has not been added to the js-legacy client yet.

Summary of Changes

The confidential transfer extension will be added to the js client in a sequence of PRs. In this PR, the InitializeMint and UpdateMint instructions are added.

@samkim-crypto samkim-crypto marked this pull request as ready for review January 13, 2025 08:22
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly tiny things, looks good overall!

clients/js-legacy/package.json Show resolved Hide resolved
confidentialTransferMintAuthority = Keypair.generate();
autoApproveNewAccounts = true;
auditorKeypair = ElGamalKeypair.newRand();
auditorPubkey = PodElGamalPubkey.encode(auditorKeypair.pubkey_owned());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit for zk-sdk: the function should be called pubkeyOwned()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I realized that. It is fixed in anza-xyz/agave#4315.

Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@samkim-crypto samkim-crypto merged commit c0c98ee into solana-program:main Jan 14, 2025
19 checks passed
samkim-crypto added a commit to samkim-crypto/token-2022 that referenced this pull request Jan 30, 2025
samkim-crypto added a commit to samkim-crypto/token-2022 that referenced this pull request Jan 30, 2025
joncinque pushed a commit that referenced this pull request Jan 30, 2025
…ializeMint` and `UpdateMint` (#61)" (#146)

Revert "[js-legacy] Add confidential transfer `InitializeMint` and `UpdateMint` (#61)"

This reverts commit c0c98ee.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants