Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[js-legacy] Add pausable extension #59

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

samkim-crypto
Copy link
Contributor

@samkim-crypto samkim-crypto commented Jan 11, 2025

Problem

The pausable extension has not yet been added to the js-legacy client.

Summary of Changes

Added the pausable extension to the js-legacy client.

@samkim-crypto samkim-crypto force-pushed the js-legacy-pausable branch 2 times, most recently from f2685ec to 4c9beda Compare January 13, 2025 08:25
@samkim-crypto samkim-crypto marked this pull request as ready for review January 13, 2025 08:51
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Just the tiny bit on the helper function

clients/js-legacy/src/extensions/extensionType.ts Outdated Show resolved Hide resolved
clients/js-legacy/src/extensions/extensionType.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@samkim-crypto samkim-crypto merged commit ae984d6 into solana-program:main Jan 14, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants