-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use bpf-entrypoint feature #27
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One little comment: we will need to build the program with the bpf-entrypoint
feature enabled so the clients tests work:
At the moment it is not an issue since we don't have clients tests, so we could do it either in this PR or in a future one.
ty for doing this, i was aware of the feature switch but it slipped my mind maybe unrelated to this pr but is there a better ux for the new paradigm than always supplying |
I was considering adding it to the |
yea if added it would need to check if the feature exists in Cargo.tom because if you specify the flag and the feature doesnt exist then cargo will halt with an error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! Can you also add the feature to scripts/program/build.mjs
?
The rest of the programs we've written in BPF have swapped
no-entrypoint
forbpf-entrypoint
, where the feature is now additive to enable the program ELF's entrypoint binding.This change brings the Stake program into that same pattern.