Refactor - Improve load immediate machinecode efficiency in JIT #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)) and emit_sanitized_load_immediate().
…te()) and emit_sanitized_load_immediate().
LucasSte
reviewed
Dec 5, 2024
src/jit.rs
Outdated
| OperandSize::S64 if value >= i32::MIN as i64 && value <= i32::MAX as i64 => { | ||
| let key = self.diversification_rng.gen::<i32>() as i64; | ||
| self.emit_ins(X86Instruction::load_immediate(size, destination, value.wrapping_sub(key))); | ||
| self.emit_ins(X86Instruction::load_immediate(OperandSize::S64, destination, value.wrapping_sub(key))); |
There was a problem hiding this comment.
Changing the size parameter in these calls has no effect, because you are already matching the size to OperandSize::S64 in the match statement. Perhaps we should leave size there for consistency?
There was a problem hiding this comment.
The size parameter was removed so it has to be explicit now.
LucasSte
approved these changes
Dec 5, 2024
Lichtso
deleted the
refactor/improve_load_immediate_encoding_efficiency
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.