Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new syscall instruction to interpreter and jitter #621

Merged
merged 9 commits into from
Nov 6, 2024

Conversation

LucasSte
Copy link

@LucasSte LucasSte commented Oct 20, 2024

This PR builds on top of #620 (implementing SIMD-0178) and introduces the new syscall instruction to the interpreter and jitter. It revamps the execution tests to deal with two syscall models and write extra tests for the changed code fragments.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.61%. Comparing base (1223789) to head (805fb4f).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #621      +/-   ##
==========================================
- Coverage   90.09%   89.61%   -0.49%     
==========================================
  Files          22       22              
  Lines        9726    10002     +276     
==========================================
+ Hits         8763     8963     +200     
- Misses        963     1039      +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasSte LucasSte requested a review from Lichtso October 22, 2024 15:09
@LucasSte LucasSte marked this pull request as ready for review October 22, 2024 15:09
src/interpreter.rs Outdated Show resolved Hide resolved
tests/execution.rs Outdated Show resolved Hide resolved
@LucasSte LucasSte force-pushed the exec-1 branch 2 times, most recently from 3fc3510 to e997952 Compare October 22, 2024 21:23
@LucasSte LucasSte requested a review from Lichtso October 22, 2024 21:30
@Lichtso
Copy link

Lichtso commented Oct 28, 2024

Can you move the execution tests with:

    let config = Config {
    test_syscall_asm!(
        enabled_sbpf_versions: SBPFVersion::V1..=SBPFVersion::V1,
        ..Config::default()
    };

down to the // SBPFv1 only [DEPRECATED] section?

And remove the syscall parameters from test_interpreter_and_jit_asm!.

src/interpreter.rs Outdated Show resolved Hide resolved
@LucasSte LucasSte merged commit 73f0e76 into solana-labs:main Nov 6, 2024
12 checks passed
@LucasSte LucasSte deleted the exec-1 branch November 6, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants