-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new syscall
instruction to interpreter and jitter
#621
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #621 +/- ##
==========================================
- Coverage 90.09% 89.61% -0.49%
==========================================
Files 22 22
Lines 9726 10002 +276
==========================================
+ Hits 8763 8963 +200
- Misses 963 1039 +76 ☔ View full report in Codecov by Sentry. |
3fc3510
to
e997952
Compare
Can you move the execution tests with: let config = Config {
test_syscall_asm!(
enabled_sbpf_versions: SBPFVersion::V1..=SBPFVersion::V1,
..Config::default()
}; down to the And remove the syscall parameters from |
This PR builds on top of #620 (implementing SIMD-0178) and introduces the new syscall instruction to the interpreter and jitter. It revamps the execution tests to deal with two syscall models and write extra tests for the changed code fragments.