Refactor - Make FunctionRegistry accept dense indexes
#617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasSte
commented
Oct 17, 2024
| } | ||
| } | ||
|
|
||
| impl<T: Copy + PartialEq + ContextObject> FunctionRegistry<BuiltinFunction<T>> { |
There was a problem hiding this comment.
I still want to add a few unit tests for these functions.
Lichtso
reviewed
Oct 17, 2024
Lichtso
reviewed
Oct 17, 2024
| pub fn keys(&self) -> Box<dyn Iterator<Item = u32> + '_> { | ||
| match self { | ||
| FunctionRegistry::Sparse(map) => Box::new(map.keys().copied()), | ||
| FunctionRegistry::Dense(vec) => Box::new(1..=(vec.len() as u32)), |
Lichtso
reviewed
Oct 17, 2024
| .map(|(key, (name, value))| (*key, (name.as_slice(), *value))), | ||
| ), | ||
| FunctionRegistry::Dense(vec) => { | ||
| Box::new(vec.iter().enumerate().map(|(idx, value)| { |
Lichtso
reviewed
Oct 17, 2024
| @@ -350,6 +420,41 @@ macro_rules! declare_builtin_function { | |||
| }; | |||
| } | |||
|
|
|||
| /// Tombstone function for when we call an invalid syscall (e.g. a syscall deactivated through a | |||
There was a problem hiding this comment.
"when we call" makes it sound like runtime when it is about verification instead. Maybe "for leaving gaps in a sparse function registry"
Lichtso
reviewed
Oct 17, 2024
| vm.context_object_pointer | ||
| .consume(vm.previous_instruction_meter - vm.due_insn_count); | ||
| } | ||
| vm.program_result = ProgramResult::Err(EbpfError::SyscallError(Box::new( |
There was a problem hiding this comment.
could also add a debug_assert!(false); to indicate that this is never supposed to actually run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea behind this PR is to allow the registration of syscalls with integers.