Refactor - Virtual Address Constants #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lichtso
force-pushed
the
refactor/virtual_address_constants
branch
2 times, most recently
from
c633d91 to
255752b
Compare
Lichtso
force-pushed
the
refactor/virtual_address_constants
branch
from
255752b to
5fc2bdd
Compare
Lichtso
commented
Oct 15, 2024
| @@ -2815,27 +2812,6 @@ fn test_err_instruction_count_syscall_capped() { | |||
| ); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_non_terminate_early() { | |||
There was a problem hiding this comment.
This test is a duplicate of test_err_callx_oob_low()
LucasSte
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SBPFv1 allows multiple readonly sections and a single text section. All of them are concatenated and mapped into the same memory region named
MM_PROGRAM_START.Going forward we want to separate the bytecode (of the text section) out into its own (unmapped) region named
MM_BYTECODE_START, which will only be executable and neither readable nor writable for memory accesses.The
MM_PROGRAM_STARTregion will then becomeMM_RODATA_STARTbecause it will be readable only, and not executable anymore.Also exports a constant
MM_REGION_SIZEto make it easier to have multiple input sectionsMM_INPUT_START + MM_REGION_SIZE * index.